oxidecomputer / oxidecomputer/propolis
crucible: shouldn't start scrub before activating volume
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
in block/crucible.rs we kick off a scrub of the volume. the scrub code asks a reasonable question: XXX Can we assert the volume is activated?
well. not really. propolis kicks off the scrub and then activates the volume a little later in Backend::start. it seems like the scrub works by the good graces of the 120s start delay that Propolis provides.
in practice there's no reason to have a propolis-server sitting ready but with backends not started for two minutes, so we don't hit this. but it's not really.... right.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/propolis/src/block/crucible.rs, comparing the scrub kickoff around the linked lines with volume activation in Backend::start. Trace the startup ordering and the activation assertion in Crucible's volume.rs. Done means scrubbing no longer begins before the volume is activated and startup does not rely on the 120-second delay.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100