oxidecomputer / oxidecomputer/progenitor

type paths are poorly formatted in strings

Open
#439 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1k
Forks
136
Avg merge
8h 36m
Merged PRs (30d)
14

Description

For example:
https://github.com/oxidecomputer/progenitor/blob/f6f957f89f0c7211afa5a2e2687b675f6919819a/progenitor-impl/tests/output/nexus-builder.out#L20873-L20876

            self.id = value
                .try_into()
                .map_err(|_| "conversion to `uuid :: Uuid` for id failed".to_string());
            self

We should clean that up.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with progenitor-impl/tests/output/nexus-builder.out around lines 20873-20876 and inspect how the shown Rust error string is generated. Trace the type-path formatting entry point, then verify the generated message uses normal Rust path spacing, such as uuid::Uuid rather than uuid :: Uuid.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.