oxidecomputer / oxidecomputer/progenitor

httpmock generation fails for query params with array types (e.g., Vec<T>)

Open
#1,260 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1k
Forks
136
Avg merge
8h 36m
Merged PRs (30d)
14

Description

The httpmock generator currently stringifies all query/header/path params via value.to_string() (see progenitor-impl/src/httpmock.rs). This implicitly requires Display and only supports single-value params.

For array query params (e.g., Vec), Display isn’t implemented and the generated mocks won’t compile.

It also doesn’t match the client’s actual query encoding (QueryParam uses serde and supports arrays by repeating the key). Should switch httpmock query matching to use the same serialization logic as the client.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in progenitor-impl/src/httpmock.rs and inspect how query, header, and path parameters are currently stringified. Compare httpmock query matching with the client's QueryParam serde encoding, including repeated keys for arrays, then verify that generated mocks compile for array query parameters such as Vec.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.