oxidecomputer / oxidecomputer/prettier-plugin-asciidoc

descriptionPrinting replays a description item per word where reflow would be render-equal; 400 of the 416 held-break confluence pairs are its

Open
#321 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

conformance mechanism:reflow-join obligation:confluence
Dominant language
TypeScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

What this is

The 416 descriptionItemHeldBreak pairs in tests/conformance/confluence-exceptions.ts are identity replays by descriptionPrinting (src/parse/lines/description-list.ts), not by the mechanism the row used to name (measured Sep 7 by the #306 lane and its review of record). Forcing that function's per-word arms (B, E, the paired-shape clause) to reflow in a scratch tree clears 400 of the 416 pairs (416 to 16). The cost today: 25 render losses in tests/format/description-sweep.test.ts, a line-END family (#148/#180's territory), and 17 tests red.

The change

Decide the line-end question first (which of the 25 are the em-dash/run families #148 and #180 own, and which are the description item's own), then delete the per-word replay arms and let the packer's reader verdict (#306) decide the description item like every other prose block. Score the 416 pairs before and after; the 16 that stay are named.

Related

#195, #306, #148, #180, #119.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/parse/lines/description-list.ts, tests/conformance/confluence-exceptions.ts, and tests/format/description-sweep.test.ts; review the related issues and the #306 lane before changing behavior. Resolve which line-end cases belong to this item versus #148 and #180, then compare the 416 pairs before and after, with the remaining 16 named and the affected tests accounted for.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.