oxidecomputer / oxidecomputer/packer-plugin-oxide
Run `make test` and `make plugin-check` in CI
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2
- Forks
- 1
- Avg merge
- 3h 9m
- Merged PRs (30d)
- 3
Description
Problem
.github/workflows/build-test.yml only runs make build, make lint, and a generated-docs diff check. No workflow runs go test at all, and the Makefile's plugin-check target (which validates the plugin binary against Packer's plugin contract via packer-sdc plugin-check) is never invoked in CI.
This means regressions like the -force panic (oxidecomputer/packer-plugin-oxide#101) can land with green CI.
Fix
- Add
make testtobuild-test.yml(unit tests run without credentials since acceptance tests are gated behindPACKER_ACC). - Add
make plugin-checktobuild-test.yml. - Depends on there being unit tests worth running — see the companion unit-test issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/build-test.yml and inspect the Makefile definitions for test and plugin-check. Update the workflow so both targets run alongside the existing checks, then confirm CI executes unit tests without PACKER_ACC credentials and validates the plugin binary.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- ci-cd, tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100