oxidecomputer / oxidecomputer/p4
Need to sanitize "final"
Open
Nobody has claimed this yet.
bug
codegen
rust
- Dominant language
- Rust
- Stars
- 137
- Forks
- 12
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 3
Description
Similar to type, we cannot generate rust fields with the name final because this is a reserved keyword.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the existing handling for the type field name in the Rust code generator and compare how reserved keywords are sanitized. Extend the equivalent behavior to final, then verify that generated Rust fields no longer use the reserved keyword.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100