oxidecomputer / oxidecomputer/p4

Space should always be required between types and identifiers.

Open
#159 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug front-end
Dominant language
Rust
Stars
137
Forks
12
Avg merge
4d 22h
Merged PRs (30d)
3

Description

Curiously the compiler accepts this

action foo(bit<12>bar) {
}

Noticed here:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided P4 snippet and trace the compiler's parsing entry point for type and identifier boundaries. Add a regression test showing that the missing-space form is rejected, while the correctly spaced form remains accepted.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.