oxidecomputer / oxidecomputer/oxide.ts
Add `ok: true` to `ApiResult` success arm
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 33
- Forks
- 4
- Avg merge
- 6d 9h
- Merged PRs (30d)
- 4
Description
After doing the usage example in #240 I noticed it feels noisy to do result.type === ‘success’.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the TypeScript sources for ApiResult and review the usage example referenced in #240 to locate the success arm. Done means the success result exposes the requested ok value and the example or relevant type checks continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100