oxidecomputer / oxidecomputer/oxide.rs
panic if the file passed to `--json-body` doesn't parse properly as the expected type
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 75
- Forks
- 21
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 19
Description
@smklein hit this today due to a mismatch between the types in the CLI and omicron
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the CLI handling for the --json-body option and reproduce the panic with a file whose JSON does not match the expected type. Trace how the mismatch between the CLI and omicron is handled, then add coverage showing that invalid input is reported without panicking.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100