oxidecomputer / oxidecomputer/oxide-cloud-controller-manager
Use InstanceNetworkInterfaceListAllPages for NIC listing
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 6
- Forks
- 2
- Avg merge
- 2h 5m
- Merged PRs (30d)
- 14
Description
Context
InstanceMetadata (internal/provider/instances_v2.go) calls InstanceNetworkInterfaceList and reads only the first results page. Oxide's per-instance NIC cap makes this safe in practice today, but the oxide.go SDK provides InstanceNetworkInterfaceListAllPages, which removes the question permanently.
Scope
Replace the single-page call with the AllPages variant; update the oxideInstanceClient interface and test fakes accordingly.
Done when
NIC listing cannot silently truncate, and mocks/tests reflect the new interface method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in internal/provider/instances_v2.go and trace the NIC listing through the oxideInstanceClient interface. Run the relevant provider tests, then update the test fakes and verify that the interface and mocks use the all-pages listing and cannot silently truncate NICs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 86/100