oxidecomputer / oxidecomputer/opte
Benchmarks: plots not saved or compared for `alloc_sz/_ct` benchmarks
Open
Nobody has claimed this yet.
bug
repo
- Dominant language
- Rust
- Stars
- 77
- Forks
- 11
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 8
Description
Criterion has some issues around handling of our allocation count/size benchmarks.
- Values of
0are never accepted, even for a custom measurement type. Unfortunately, we often desire having zero allocations! - The values produced by these benchmarks are causing NaN propagation somewhere within criterion. This directly prevents plotting of results as well as saving estimates/tukey values for our allocation benchmarks.
We should take some time to work on the upstream library to improve these pain points.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the alloc_sz/_ct benchmarks and tracing how Criterion handles zero values and NaN results. The work is complete when these benchmarks can be plotted and their estimates and Tukey values are saved and compared without NaN propagation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100