oxidecomputer / oxidecomputer/opte
xde: error on add_unicast should reflect underlying error
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 77
- Forks
- 11
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 8
Description
In this code we just set errno to EFAULT, which is confusing for debugging. The errno should be the underlying error code from e.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open xde/src/xde.rs at lines 947-950 and inspect the add_unicast error path. Replace the confusing EFAULT result with the underlying error code from e, then verify that the reported errno reflects that underlying error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100