oxidecomputer / oxidecomputer/opte
Validate names of xde devices on creation
Open
Nobody has claimed this yet.
good first issue
- Dominant language
- Rust
- Stars
- 77
- Forks
- 11
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 8
Description
Converted from TODO here. We need to verify that the provided UTF8 name for an xde device is a valid C string. That's actually done in the new_port function here, but we should move this validation outside the lock taken at the beginning of create_xde. We may want to just fail this in a constructor of CreateXdeReq itself.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read xde/src/xde.rs, starting with create_xde, new_port, and the CreateXdeReq definition. Move the existing UTF-8 name validation so it occurs before create_xde takes its lock, and verify the existing xde checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100