oxidecomputer / oxidecomputer/opte
Moment raw/atomic timestamps should be represented as `AtomicI64`
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 77
- Forks
- 11
- Avg merge
- 9d 20h
- Merged PRs (30d)
- 8
Description
hrtime_t is equivalent to i64, so we should not be exporting the raw timestamp value as a u64 (or using it in flow entries as an AtomicU64, for that matter).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/opte/src/ddi/time.rs lines 96-106 and trace the raw timestamp type into flow entries. Confirm the hrtime_t representation and update the exported value and flow-entry atomic type to match it, then check for remaining u64 or AtomicU64 uses in this timestamp path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100