oxidecomputer / oxidecomputer/omicron

`cargo xtask releng --output-dir` seems to assume absolute path?

Open
#9,956 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

I tried this:

$ cargo xtask releng --output-dir=./tuf-repo
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.54s
     Running `target/debug/xtask releng --output-dir=./tuf-repo`
    Finished `release` profile [optimized] target(s) in 0.74s
     Running `target/release/omicron-releng --output-dir=./tuf-repo`
Mar 02 13:55:48.168 DEBG changing working directory to /home/dap/omicron-work
Mar 02 13:55:48.268 DEBG running: git rev-parse HEAD
Mar 02 13:55:48.272 DEBG process exited with exit status: 0 (4.154426ms)
Mar 02 13:55:48.272 INFO version: 19.0.0-0.local+gitc0717a4a94e
Mar 02 13:55:48.281 DEBG running: git -C /home/dap/helios rev-parse --verify HEAD^{commit}
Mar 02 13:55:48.286 DEBG process exited with exit status: 0 (4.508662ms)
Mar 02 13:55:48.286 DEBG running: git ls-remote --exit-code https://github.com/oxidecomputer/helios.git HEAD
Mar 02 13:55:49.601 DEBG process exited with exit status: 0 (1.31488929s)
Mar 02 13:55:49.601 DEBG running: pkg verify -q /system/zones/brand/omicron1/tools
Mar 02 13:55:50.617 DEBG process exited with exit status: 0 (1.016342383s)
Mar 02 13:55:50.617 DEBG running: zfs list rpool/images/dap/host
NAME                    USED  AVAIL     REFER  MOUNTPOINT
rpool/images/dap/host    24K  41.8G       24K  /rpool/images/dap/host
Mar 02 13:55:50.623 DEBG process exited with exit status: 0 (5.576018ms)
Mar 02 13:55:50.623 DEBG running: zfs list rpool/images/dap/recovery
NAME                        USED  AVAIL     REFER  MOUNTPOINT
rpool/images/dap/recovery    24K  41.8G       24K  /rpool/images/dap/recovery
Mar 02 13:55:50.628 DEBG process exited with exit status: 0 (5.848111ms)
Mar 02 13:55:50.629 INFO [hubris-production] running task
Mar 02 13:55:50.629 INFO [helios-incorp] running task
Mar 02 13:55:50.629 INFO [hubris-staging] running task
Mar 02 13:55:50.629 INFO [helios-incorp] task succeeded (109.445µs)
Mar 02 13:55:50.629 INFO [omicron-package] running: ptime -m /claude/.rustup/toolchains/1.91.1-x86_64-unknown-illumos/bin/cargo build --locked --release --bin omicron-package
Mar 02 13:55:50.631 INFO [helios-setup] running: BUILD_OS=no PWD=/home/dap/helios ptime -m gmake setup
[    helios-setup] cd tools/helios-build && cargo build --quiet
[ omicron-package]     Blocking waiting for file lock on package cache
Mar 02 13:55:51.856 ERRO [hubris-staging] task failed (1.226523434s)
Error: failed to write to file `./tuf-repo/hubris-staging/./tuf-repo/hubris-staging/a5f17a81c251cc34fb19b87eda48c521bcf1bcd8f433b0694cd7009603f52fe4.zip`: No such file or directory (os error 2)

when I passed $PWD/tuf-repo instead, it got past that error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with cargo xtask releng --output-dir=./tuf-repo, then compare it with the working $PWD/tuf-repo invocation. Start at the cargo xtask releng and omicron-releng entry points mentioned in the output; done means a relative output directory works without duplicating the path and produces the expected repository files.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.