oxidecomputer / oxidecomputer/omicron

Wicket Chokes on Static Config...Misses BGP

Open
#9,808 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

We just encountered this at a customer using static routes instead of BGP; when you try to use the config for setup it fails with an error regarding the missing BGP config.

The fix is to make sure we have a dummy BGP section - bgp = [] after the [rack_network_config] section, such as:

# TODO: docs on network config
[rack_network_config]
infra_ip_first = "x.x.x.x"
infra_ip_last = "y.y.y.y"
bgp = []

This seems to have fixed the issue. We should probably handle this slighly more gracefully.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing setup with a static-routes configuration that omits the BGP section, then trace the configuration parsing and setup path that reports the missing BGP config. The issue is done when static configuration works without requiring a dummy bgp = [] section and the existing failure case is covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.