oxidecomputer / oxidecomputer/omicron
Log the entire error chain when sled-agent cannot communicate with nexus
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
When sled-agent fails to communicate with Nexus, it doesn't log the underlying error.
Example:
01:13:21.478Z WARN SledAgent: Received Error from Nexus for Get request: Communication Error: error sending request for url (http://_nexus._tcp.control-plane.oxide.internal:12221/sled-agents/<SLED_ID>)
file = sled-agent/src/nexus.rs:530
sled_id = <SLED_ID>
This issue is to ask for logging the whole error chain.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sled-agent/src/nexus.rs around line 530, where the communication error is logged. Trace the error handling to identify how the underlying chain is currently represented, then verify the resulting log includes the full chain when sled-agent cannot communicate with Nexus.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100