oxidecomputer / oxidecomputer/omicron
sled-agent config reconciler should not block on key-retrieval
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
calls to Disk::new which happen inside the sled-agent config-reconciler block waiting for trust quorum to remotely retrieve key shares and reconstruct the rack secret. This is very quick when everything is healthy, but if there is network weather will block the reconciler indefinitely.
We should probably spawn a task for each Disk::new call and poll those from the reconciler.
CC @plaidfinch @jgallagher
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sled-agent config reconciler and trace its Disk::new call sites, focusing on how key retrieval currently runs and how reconciliation observes progress. Done means network delays during trust-quorum key retrieval no longer block the reconciler indefinitely while successful disk setup still completes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100