oxidecomputer / oxidecomputer/omicron
`omicron-dev run-all` depends on libipcc?!
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
I've noticed this before but @lgfa29 mentioning it is what nudged me to actually figure out why I'd seen it: omicron-dev depends on gateway-test-utils to get gateway_test_utils::setup::DEFAULT_SP_SIM_CONFIG, but that also has gateway-test-utils -> omicron-gateway -> illumos-utils -> ipcc -> libipcc. and at that point, if you're on an illumos system but not Helios (such as an OmniOS), we'll try linking against non non-existent libipcc and die with = note: ld: fatal: library -lipcc: not found.
in the past I'd worked around this by patching the libipcc dependency locally to use the mocks even on illumos, but it's an awkward patch to carry and seems pretty solvable with a bit of motion here.
edit: there's a second (more direct) path to ipcc too, which is through nexus-test-utils. that directly depends on omicron-sled-agent.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the omicron-dev run-all entry point and inspect the dependency declarations for the paths through gateway-test-utils and nexus-test-utils to ipcc. Reproduce the link failure on a non-Helios illumos system, then verify that run-all no longer requires the unavailable libipcc library there.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100