oxidecomputer / oxidecomputer/omicron
Probe zone creation needs to be in a transaction
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Converting the TODO from here:
to a proper issue. This creates an external IP address, network interface, and finally the probe itself. These should be in a transaction or otherwise concurrency-safe.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at nexus/db-queries/src/db/datastore/probe.rs around lines 253-263 and trace probe-zone creation through external IP address, network interface, and probe creation. Ensure these operations are transactional or otherwise concurrency-safe, then verify the creation flow cannot leave partial resources behind.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, database
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100