oxidecomputer / oxidecomputer/omicron

`blippy` should check that a decommissioned sled has no in-service zones

Open
#9,186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

I was manually tweaking a Blueprint in some unit tests, and was mildly surprised that Blueprint::all_omicron_zones(BlueprintZoneFilter::is_in_service) returned zones on a sled I had marked as in SledState::Decommissioned. When the planner decommissions a sled, it also expunges everything on that sled, so I think the actual bug here is in my test (if I'm going to decommission a sled, I should also expunge all its zones). blippy could (and should) check this invariant.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the blippy checks around Blueprint::all_omicron_zones, BlueprintZoneFilter::is_in_service, and SledState::Decommissioned. Review how the planner handles decommissioned sleds, then add the invariant check so a decommissioned sled cannot retain in-service zones and verify it with the relevant blippy tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.