oxidecomputer / oxidecomputer/omicron
evaluate update-related datastore functions for `check_complex_operations_allowed`
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
opctx.check_complex_operations_allowed()?; should be called in datastore methods that either do not paginate or paginate on behalf of the caller, particularly the artifacts_for_repo function. (Once #9106 lands we should be able to do this.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nexus/db-queries/src/db/datastore/update.rs, especially the artifacts_for_repo function, and review the other update-related datastore methods for their pagination behavior. Confirm the prerequisite work in #9106 is available, then determine which relevant methods need the check_complex_operations_allowed call; done means all applicable methods enforce the intended check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100