oxidecomputer / oxidecomputer/omicron
[sled-agent] Report errors adopting internal disks
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Inside the config-reconciler, sled-agent attempts to automatically adopt any internal (M.2) disk: https://github.com/oxidecomputer/omicron/blob/2dd0b7c2a029ce8e3833ea1a69b436e480defbbb/sled-agent/config-reconciler/src/internal_disks.rs#L779-L783
If this fails, we record an error, but these are currently not reported up to Nexus in any way. We could add them to inventory, or maybe this belongs in fault management? The reconciler currently stashes them in a watch channel that is not read by anyone: https://github.com/oxidecomputer/omicron/blob/2dd0b7c2a029ce8e3833ea1a69b436e480defbbb/sled-agent/config-reconciler/src/internal_disks.rs#L309-L316
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sled-agent/config-reconciler/src/internal_disks.rs, especially the internal-disk adoption code at lines 779-783 and the watch channel setup at lines 309-316. Trace how adoption errors are stored and determine whether inventory or fault management should report them to Nexus. Done means failed internal-disk adoption errors are no longer stranded in an unread watch channel and are reported through the selected path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100