oxidecomputer / oxidecomputer/omicron
MGS driven SP components left in invalid state should have a way to recover from failed updates
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Specifically in the case of the RoT, it could be left in an un-updateable state. In the case of there being a bad signature check on the alternate RoT image, either the pending-persistent or just the persistent boot preference will need to be set to the good image before proceeding.
We could add a variant to UpdateAttemptStatus called RestoringComponent (or similar) and have apply_update set the status to this new status if the component needs to be set to a different state before an update. This could happen after a precheck.
Needs https://github.com/oxidecomputer/hubris/pull/2050 to fully work
To be able to differentiate whether an RoT has a mismatch with the active version and persistent boot preference or transient/pending boot preference are not empty due to a failed update or an ongoing update we'll need https://github.com/oxidecomputer/hubris/issues/2066 which will be available soon.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the UpdateAttemptStatus type and the apply_update and precheck paths described in the issue. Review hubris#2050 and issue#2066 to understand the required component and boot-preference behavior. Done should provide a recovery state for components needing restoration and allow failed or ongoing RoT updates to be distinguished from a normal preference mismatch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100