oxidecomputer / oxidecomputer/omicron

Break up the `SwitchPortSettingsManager` RPW into smaller independently testable chunks.

Open
#8,223 0 comments 0 reactions 1 assignee View on GitHub

@internet-diglett is already working on this.

Since May 27, 2025.

development networking Testing & Analysis
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

When working on #8213 I struggled a bit on how to write a test that a) captures #8207 in the current codebase, and then works with the fix in place. This is because the RPW implementation below has command and control intertwined with the diff calculations that feed into that c&c. If we could separate out the diff calculation part (similar to what I believe we're doing for blueprints) from the code carrying out actions based on those diffs, then we could test this code much more easily I think.

https://github.com/oxidecomputer/omicron/blob/37a2122e4be0d947c141833a695bf11a1c32f537/nexus/src/app/background/tasks/sync_switch_configuration.rs#L291-L1330

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.