oxidecomputer / oxidecomputer/omicron
Break up the `SwitchPortSettingsManager` RPW into smaller independently testable chunks.
Open
@internet-diglett is already working on this.
Since May 27, 2025.
development
networking
Testing & Analysis
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
When working on #8213 I struggled a bit on how to write a test that a) captures #8207 in the current codebase, and then works with the fix in place. This is because the RPW implementation below has command and control intertwined with the diff calculations that feed into that c&c. If we could separate out the diff calculation part (similar to what I believe we're doing for blueprints) from the code carrying out actions based on those diffs, then we could test this code much more easily I think.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.