oxidecomputer / oxidecomputer/omicron
`OmicronZoneConfig::filesystem_pool` should be non-optional
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
#7549 changed BlueprintZoneConfig to make filesystem_pool non-optional; we should do the same to OmicronZoneConfig to remove some "this should never happen" error paths in sled-agent.
Loosely related to #7214 - it would be nice to track datasets explicitly by ID rather than implicitly by "the zone type + the zpool"; making "the zpool" required may help with that transition.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the change from #7549 and locate the definitions and usages of BlueprintZoneConfig and OmicronZoneConfig, including the sled-agent error paths. Update the OmicronZoneConfig filesystem_pool handling consistently, then run the relevant Rust checks and tests to confirm the impossible paths are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100