oxidecomputer / oxidecomputer/omicron
sled-agent inventory skips zpools it can't query
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
- Should we make it possible to report "partial inventories" when a zpool/dataset is in a bad state, and we can't query it? E.g., should we report "this zpool exists, but we can't query info about it"?
- ... or are we okay with this current disposition, where we can see a zpool, we think it might exist, but we'll drop it from inventory entirely unless it responds "Ok" to enough requests?
Originally posted by @smklein in https://github.com/oxidecomputer/omicron/pull/8180#discussion_r2093446609
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the sled-agent inventory handling discussed in pull request #8180 and the questions in this issue about unqueryable zpools and datasets. Determine whether partial inventories should be reported or failed queries should continue to omit the zpool; done requires an agreed behavior and corresponding implementation or decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100