oxidecomputer / oxidecomputer/omicron
releng should deduplicate generated release incorporations
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
#8092 added generation of the omicron-release-incorporation package. Right now the latest version of every package in the repository is present (except omicron-release-incorporation itself, and /driver/network/opte).
This includes packages that are already part of listed incorporations, so you have osnet-incorporation@2.0.23336, and dozens of various packages that are part of osnet at the same version. If something in this incorporation needs to be backported on a release branch, this involves fixing very many lines in the manifest.
It would be nice to check incorporations and not include redundant FMRIs. We may want to limit this to explicit incorporations that are installed on the image (otherwise we will not successfully pin some package versions).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review #8092 and the generation path for the omicron-release-incorporation package, focusing on how package FMRIs are collected into release manifests. Determine how explicit incorporations installed on the image should be handled, then verify that redundant FMRIs are omitted without preventing package-version pinning for backports.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- release
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100