oxidecomputer / oxidecomputer/omicron

Consider more robust notification to metrics task that time is synchronized

Open
#8,022 4 comments 0 reactions 1 assignee View on GitHub

@jgallagher is already working on this.

Since Apr 22, 2025.

Metrics Sled Agent
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

The sled-agent does a bunch of stuff once time has been synchronized. One action is notifying the internal metrics task, so that it can start to reliably produce timestamps for metric data. That's here:

https://github.com/oxidecomputer/omicron/blob/d9ba2835366709b1730619e78000d25831370061/sled-agent/src/services.rs#L4206-L4212

That notification is fallible, and the failure is pretty bad: we'll never produce metrics for this sled, at least those based on kstats. We should consider retrying this or waiting for this to succeed instead.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.