oxidecomputer / oxidecomputer/omicron

Disk delete request hangs when backing saga gets stuck

Open
#8,011 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

The disk delete request to nexus currently awaits the underlying disk delete saga. This means that if the delete saga gets stuck (due to a bad downstairs) the request will hang an never complete. In the console this is presented as an indefinite spinner. If the user cancels or stops waiting for their request and re-lists the disks (or attempts to delete the disk again) it will be reported as missing as the first step of the delete saga is to mark the resource record as deleted and the user is viewing the state of the system mid-saga.

Does it makes sense to have some maximum number of retries for any fallible step when a saga is being run in a synchronous request? or maybe there should be an intermediate state of deleting to indicate that the disk is still in the process of being deleted.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Nexus disk-delete request and its underlying disk-delete saga described here. Clarify whether the intended behavior is bounded retries or an explicit deleting state, then define and test what completion means when a downstream operation is stuck.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.