oxidecomputer / oxidecomputer/omicron
wicket: bgp `port` configuration is redundant with `rack_network_config.switch*.port`
Open
Nobody has claimed this yet.
networking
wicket
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
The toml file that wicket takes in has a fomat that looks like this
[rack_network_config.switch0.qsfp31]
routes = [{nexthop = "198.51.103.9", destination = "0.0.0.0/0", vlan_id = 200, local_pref = 10}]
addresses = [{address = "198.51.103.10/30", vlan_id = 200}]
uplink_port_speed = "40G"
uplink_port_fec="none"
autoneg = false
bgp_peers = [
{asn = 47, addr = "198.51.103.9", port = "qsfp31", local_pref = 20}
]
Here port = "qsfp31" is redundant with [rack_network_config.switch0.qsfp31] and introduces an opportunity for error that should not exist.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how wicket parses the TOML BGP peer configuration and how [rack_network_config.switch*.port] entries are represented. Determine where the redundant peer port is validated or consumed, then update the relevant behavior and tests so the configuration no longer requires this duplicated value.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100