oxidecomputer / oxidecomputer/omicron

keep the system from running out of disk space

Open
#7,875 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

customer
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

(This high-level issue might well get turned into smaller issues and then closed.)

Recent customer issues have highlighted several problems around storage accounting and space management.

Problems

  • The process of allocating Crucible regions assumes that Crucible can use the whole disk. This does not account for other uses of U.2 devices: namely, the root filesystems and persistent datasets of control plane zones and Propolis zones. (Anything else?)
  • The process of allocating Crucible regions does not account for Crucible overhead (a fudge factor of about 1.2-1.25x).
  • We don't have quotas or reservations in most places, so if something does go haywire, it can take a lot out with it.
  • There appears to be no process that clears old data out of debug datasets. We have deployed systems where some disks have upwards of 1 TiB of space used by these files.
  • While investigating this, we discovered #7874.

All of these can cause systems to run out of disk space, triggering various ugly failures.

Proposed steps

For R14
Longer term
  • for each consumer of disk space, on all disks (this would include: crash dumps, core dumps, GZ data, zone root filesystems, zone persistent data, etc.)
    • make an estimate of how much disk space it needs
    • figure out what steps might be necessary to keep that under its limit (e.g., log rotation, archiving, deletion)
    • update the estimate we made above (for how much Crucible is allowed to use) to reflect this
  • for crucible regions, implement measures to prevent unbound snapshot usage (e.g., pantry scrubber) so we can shrink region dataset's 3x quota
  • update Reconfigurator to apply reservations and/or quotas to implement those limits
  • update Reconfigurator to look at the storage allocated and required when placing components (so that we don't overprovision storage on disks)
  • figure out why debug datasets are sometimes not mounted and how to fix it (see: https://github.com/oxidecomputer/omicron/issues/7874)
  • implement some kind of monitoring for disk space usage (raise an active problem if datasets get full)
  • review/improve policy for deleting files from the debug dataset (current logic)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

This is a high-level umbrella issue whose R14 work is largely complete and whose remaining items span storage consumers, Crucible snapshot usage, Reconfigurator reservations, placement, monitoring, and debug-dataset cleanup. Start by reviewing the remaining checklist, the current deletion logic in sled-agent/src/dump_setup.rs, and related issue #11014; the work is ready to pursue only after being split into focused issues with specific completion criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
infrastructure
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.