oxidecomputer / oxidecomputer/omicron

would like `UpdateAndCheck` to work with multi-column primary keys

Open
#7,709 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

The UpdateAndCheck trait in nexus-db-queries allows executing a SQL UPDATE statement and, if no rows are updated, checking if a row with the provided primary key exists in the table. Presently, the primary key must be a single column for this to work. It would be nice to enhance this helper to work with multi-column primary keys, taking a tuple rather than a single value to check the existence of.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the UpdateAndCheck trait in nexus-db-queries and trace how it currently checks a single-column primary key after an UPDATE affects no rows. Done means the helper accepts a tuple for multi-column primary keys and checks for the corresponding row in the table.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.