oxidecomputer / oxidecomputer/omicron
VPC system router resolution should just query all subnets unconditionally
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
While writing #7463, it became apparent that we can make fewer queries when resolving rules for a system router:
...except we already know that we should have a route for every VpcSubnet, so don't really need to bother with resolving names one-by-one as they appear in the routeset. We should just request the full paginated list here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nexus/db-queries/src/db/datastore/vpc.rs around lines 2563-2584 and read how system-router rules currently resolve subnet names. Change the lookup to request the full paginated list of VpcSubnet records, then verify that route resolution uses that list rather than querying names individually.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases, networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100