oxidecomputer / oxidecomputer/omicron

wicket RSS display includes includes rack_network_config.bgp output as a sub item of the final uplink

Open
#7,391 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

wicket
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

We had a config-rss.toml with 4 BGP uplinks, and a final few lines for an asn and the originate array.

After the uplink configuration information, the toml file had this:

[[rack_network_config.bgp]]
asn = 65019
originate = ["10.101.240.0/21", "10.101.248.0/21"]

In the wicket screen when verifying the configuration before RSS, this item was included as a
member of the final uplink, and not an element on its own line as I believe it should have been:

Here is a small section of the output on wicket

 │                  ││Uplink 4: 
 │                  ││  • Port          : qsfp30 on switch switch1
 │                  ││  • Speed         : 100G  
 │                  ││  • FEC           : None   
 │                  ││  • Autoneg       : disabled  
 │                  ││  • Address       : 10.99.255.14/30 
 │                  ││  • BGP peer      : 10.99.255.13 asn=64044 port=qsfp30 
 │                  ││    Intervals     : hold=18s idle_hold=13s delay_open=0s connect_retry=30s keepalive=6s 
 │                  ││    Auth key      : key: TCP-MD5 (SHA-256: <sha hash redacted>) 
 │                  ││  • BGP config    : asn=65019 originate=10.101.240.0/21,10.101.248.0/21 
 │                  ││NTP servers:
 │                  ││  • 172.23.109.33
 │                  ││  • 172.22.101.170
 │                  ││  • 172.23.103.110

This config did work, and set things as expected, so it's most likely a display issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the wicket screen with the supplied config-rss.toml containing four BGP uplinks and a final rack_network_config.bgp entry. Trace how the configuration is rendered after the uplink section; done means the ASN and originate values appear as a separate item rather than under Uplink 4, while RSS configuration remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.