oxidecomputer / oxidecomputer/omicron

[sled-agent] Use zone-setup-service to configure switch zone networking

Open
#7,348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Sled Agent
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Sadly, we are still using zlogin at one point of the switch zone start up flow. These actions are already performed by the zone-setup-service, but our first attempt at using the service resulted in a race.

The comments in #7337 have plenty of information on the cause of this race, and potential ways of implementing this functionality.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in sled-agent/src/services.rs at the linked switch-zone startup code, then read issue #7337 and the failed pull request #7260 for the race details and proposed approaches. The work is done when switch-zone networking is configured through zone-setup-service instead of zlogin without reintroducing the startup race.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.