oxidecomputer / oxidecomputer/omicron
Transactions should be retryable
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
This issue tracks spots where we are using non-retryable transactions:
Used in Nested Transactions:
- dns_update_incremental, in
nexus/db-queries/src/db/datastore/dns.rs
Uses Nested Transactions:
- rack_set_initialized in
nexus/db-queries/src/db/datastore/rack.rs - silo_create_conn in
nexus/db-queries/src/db/datastore/silo.rs - silo_delete in
nexus/db-queries/src/db/datastore/silo.rs
Other (just needs to be done):
- role_assignment_replace_visible in
nexus/db-queries/src/db/datastore/role.rs
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the transaction handling in the listed functions: dns_update_incremental in dns.rs, rack_set_initialized in rack.rs, silo_create_conn and silo_delete in silo.rs, and role_assignment_replace_visible in role.rs. Trace how nested and non-retryable transactions are used, then confirm that each listed spot has been updated to use retryable transactions and all checklist items are complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100