oxidecomputer / oxidecomputer/omicron

Instance Creation should allow concurrent device creation

Open
#720 6 comments 0 reactions 1 assignee View on GitHub

@smklein is already working on this.

Since Mar 8, 2022.

api nexus Remote Access Preview
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Currently, the act of merely "creating" and instance triggers it to begin running as well. In a fully device-less world, this has functioned as a convenience, but within the context of attaching disks and network interfaces, this becomes more of a pain.

In a world without hot-plug, consider the following:

  • You want to create an instance
  • You want to attach a disk to it

If you call "project_create_instance", the instance is created, immediately transitions to running, and must be stopped before a disk can be attached.

Instead, I propose that instances are initialized with the "Stopped" state, and only become allocated to a particular sled once explicitly started via instance_start. This will provide a created-but-not-started window in which devices may be attached.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.