oxidecomputer / oxidecomputer/omicron

preflight check reports `missing metadata`

Open
#7,108 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

During a RSS setup preflight check, we report a bunch of missing metadata.

On a successful run, I see a number of these lines printed:

alan@jeeves $ ssh wicket@fe80::aa40:25ff:fe05:2e02%dublin_sw1tp0 preflight uplink                                                                       
✔ Configuring switch (11.951972ms)                                                                                                                      
    configured Qsfp(Qsfp("qsfp0"))/0: ips [                                                                                                             
    UplinkAddressConfig {                                                                                                                               
        address: V4(                                                                                                                                    
            Ipv4Net {                                                                                                                                   
                addr: 172.20.15.62,                                                                                                                     
                width: 29,                                                                                                                              
            },                                                                                                                                          
        ),                                                                                                                                              
        vlan_id: None,                                                                                                                                  
    },                                                                                                                                                  
], routes [                                                                                                                                             
    RouteConfig {                                                                                                                                       
        destination: V4(                                                                                                                                
            Ipv4Net {                                                                                                                                   
                addr: 0.0.0.0,                                                                                                                          
                width: 0,                                                                                                                               
            },                                                                                                                                          
        ),                                                                                                                                              
        nexthop: 172.20.15.57,                                                                                                                          
        vlan_id: None,                                                                                                                                  
        rib_priority: None,                                                                                                                             
    },                                                                                                                                                  
]                                                                                                                                                       
✔ Waiting for L1 link up (8.523888951s)                                                                                                                 
    missing metadata                                                                                                                                    
✔ Configuring IP address in host OS (631.281056ms)                                                                                                      
    configured uplinks/qsfp0_0                                                                                                                          
✔ Configuring routing in host OS (12.510337ms)                                                                                                          
    added routes [                                                                                                                                      
    RouteConfig {                                                                                                                                       
        destination: V4(                                                                                                                                
            Ipv4Net {                                                                                                                                   
                addr: 0.0.0.0,                                                                                                                          
                width: 0,                                                                                                                               
            },                                                                                                                                          
        ),                                                                                                                                              
        nexthop: 172.20.15.57,                                                                                                                          
        vlan_id: None,                                                                                                                                  
        rib_priority: None,                                                                                                                             
    },                                                                                                                                                  
]                                                                                                                                                       
✔ Checking for external DNS connectivity (5.208714335s)                                                                                                 
    DNS server 1.1.1.1 A query attempt 1: resolved ntp.eng.oxide.computer to 172.20.0.5                                                                 
    DNS server 9.9.9.9 A query attempt 1: resolved ntp.eng.oxide.computer to 172.20.0.5                                                                 
✔ Checking for external NTP connectivity (4.261500524s)                                                                                                 
    successfully contacted NTP server 172.20.0.5                                                                                                        
✔ Cleaning up host OS routing configuration (14.820905ms)                                                                                               
    missing metadata                                                                                                                                    
✔ Cleaning up host OS IP address configuration (37.567512ms)                                                                                            
    missing metadata                                                                                                                                    
✔ Cleaning up switch configuration (14.26761ms)                                                                                                         
    missing metadata 

It's a little confusing as I'm not sure if there is a problem.
When there is an actual failure, It's more misleading as it appears that the problem is 'missing metadata':

alan@jeeves $ ssh wicket@fe80::aa40:25ff:fe05:2202%dublin_sw0tp0 preflight uplink                                                                       
✔ Configuring switch (9.71393ms)                                                                                                                        
    configured Qsfp(Qsfp("qsfp0"))/0: ips [                                                                                                             
    UplinkAddressConfig {                                                                                                                               
        address: V4(                                                                                                                                    
            Ipv4Net {                                                                                                                                   
                addr: 172.20.15.61,                                                                                                                     
                width: 29,                                                                                                                              
            },                                                                                                                                          
        ),                                                                                                                                              
        vlan_id: None,                                                                                                                                  
    },                                                                                                                                                  
], routes [                                                                                                                                             
    RouteConfig {                                                                                                                                       
        destination: V4(                                                                                                                                
            Ipv4Net {                                                                                                                                   
                addr: 0.0.0.0,                                                                                                                          
                width: 0,                                                                                                                               
            },                                                                                                                                          
        ),                                                                                                                                              
        nexthop: 172.20.15.57,                                                                                                                          
        vlan_id: None,                                                                                                                                  
        rib_priority: None,                                                                                                                             
    },                                                                                                                                                  
]                                                                                                                                                       
] Waiting for L1 link up (30.086649834s)                                                                                                                
    missing metadata                                                                                                                                    
    link state: Unknown                                                                                                                                 
* Configuring IP address in host OS (6.653µs)                                                                                                           
    missing metadata                                                                                                                                    
    link not up due to earlier failure                                                                                                                  
* Configuring routing in host OS (4.528µs)                                                                                                              
    missing metadata                                                                                                                                    
    addresses not configured due to earlier failure                                                                                                     
* Checking for external DNS connectivity (4.84µs)                                                                                                       
    missing metadata                                                                                                                                    
    skipped due to previous failure                                                                                                                     
* Checking for external NTP connectivity (3.847µs)                                                                                                      
    missing metadata                                                                                                                                    
    skipped due to previous failure                                                                                                                     
* Cleaning up host OS routing configuration (3.887µs)                                                                                                   
    missing metadata                                                                                                                                    
    routing was not configured due to earlier failure                                                                                                   
* Cleaning up host OS IP address configuration (3.907µs)                                                                                                
    missing metadata                                                                                                                                    
    addresses were not configured due to earlier failure                                                                                                
✔ Cleaning up switch configuration (13.50209ms)                                                                                                         
    missing metadata

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce both the successful and failing RSS uplink runs with the preflight uplink entry point, focusing on the steps that print missing metadata. Trace how those step results and the actual failure are rendered, then verify that successful cleanup and real failures produce distinct, useful output.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.