oxidecomputer / oxidecomputer/omicron

Duplicate "component" JSON key in log entries

Open
#6,844 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Maybe it's intentional, but I can't think of a reason. The "component" key in the log entries in a simulated Omicron environment is encountered twice:

{"msg":"collecting from producer","v":0,"name":"omicron-dev","level":20,"time":"2024-10-03T21:09:47.560547887Z","hostname":"devubuntu","pid":6084,"address":"[::1]:38053","producer_id":"a6458b7d-87c3-4483-be96-854d814c20de","component":"collection-task","collector_ip":"::1","collector_id":"39e6175b-4df2-4730-b11d-cbc1e60a2e78","component":"oximeter-agent","component":"oximeter"}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the simulated Omicron environment and inspect the log entry shown in the issue. Trace where the three "component" fields are added; done means the log output contains the intended component information without duplicate JSON keys.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.