oxidecomputer / oxidecomputer/omicron
resolver_can_be_used_with_progenitor_client can be more specific about the failure it's looking for
Open
Nobody has claimed this yet.
Good for new hires
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
We're checking for "error sending request", but we could/should check for some more specific shibboleth of a DNS failure
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at internal-dns/src/resolver.rs lines 824-838 and inspect the resolver_can_be_used_with_progenitor_client test. Determine which more specific DNS failure marker should replace the broad "error sending request" check, then update the assertion and run the relevant internal-dns tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking, testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100