oxidecomputer / oxidecomputer/omicron

update test_silo_certificates

Open
#6,716 0 comments 0 reactions 1 assignee View on GitHub

@jmpesp is already working on this.

Since Feb 4, 2025.

Good for new hires
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Theses tests are intended to validate what happens when we use the wrong certificate to connect to a silo

https://github.com/oxidecomputer/omicron/blob/ea2f4d2de939ea47780f3bf3c1bf7d2bd6007964/nexus/tests/integration_tests/certificates.rs#L588-L627

As @jmpesp notes:

I'm not sure this check is right: it looks like this part of the test is meant to check that a client can't connect using the wrong certificate, and this check is asserting it won't trust a self-signed certificate. That's not quite the same thing. I think we need either add_root_certificate or danger_accept_invalid_certs in order to test that the client accepts the self-signed cert but fails due to the incorrect certificate being used.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.