oxidecomputer / oxidecomputer/omicron
Fleet usage data in virtual_provisioning_collection should be labeled as rack usage
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
While looking at #6653, we notice that the entry with collection_type = fleet in the virtual_provisioning_collection database table should really be labeled as rack. The distinction is important as the numbers are consumed in metrics. If an external system already collected the rack usage as fleet usage, we will have to make up another collection type to aggregate multiple racks in the future and it's potentially confusing.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the virtual_provisioning_collection table and the code that assigns its collection_type, using issue #6653 for context. Confirm how the fleet entry is produced and consumed by metrics; done means the relevant rack usage is labeled rack rather than fleet without confusing existing aggregation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100