oxidecomputer / oxidecomputer/omicron
[MGS] Remove serial console endpoints?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
It's also possible we could drop this endpoint. Today if anyone attaches to the serial console it happens via faux-mgs, not MGS proper, and it doesn't seem like something we need to expose to the control plane in general.
(I think this method's existence long predates any discussions of the tech port, support keys, etc. It's possible to use it via gateway-cli usart-attach ..., but I strongly suspect that's never been used outside of its initial development.)
Originally posted by @jgallagher in https://github.com/oxidecomputer/omicron/pull/6432#discussion_r1731599881
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in gateway-cli/src/main.rs around the gateway-cli usart-attach entry point, then trace the serial console endpoint references in the repository. Confirm whether the endpoint and CLI path are still needed; done means removing the obsolete exposure and updating any affected references or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100