oxidecomputer / oxidecomputer/omicron
Modify Disk/Region management to use RegionSets
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
The current implementation of Disks, as of https://github.com/oxidecomputer/omicron/pull/511 , assumes that each disk is comprised of a single RegionSet.
Context: https://github.com/oxidecomputer/omicron/pull/511#discussion_r785669777
This artificially limits the number of regions contained within a disk to "three", which is the redundancy threshold.
In reality, disks may be comprised of multiple RegionSets, such that a larger quantity of regions are responsible.
This issue tracks the following:
- RegionSets will need to identify which sub-portion of the user volume they are responsible for managing.
- Depending on how many RegionSets may comprise a disk, we may need to start integrating pagination APIs into region access.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the disk and RegionSet implementation introduced by pull request #511 and the linked discussion. Trace how a disk currently selects and accesses its RegionSet, then identify the region-access APIs that would need pagination. Done means disks can represent multiple RegionSets, each with its managed sub-portion, without the current three-region limit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100