oxidecomputer / oxidecomputer/omicron
all sagas should be tested with actions_succeed_idempotently
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
See #6069 and #6071. We have helpers for testing action idempotency and it'd be nice to test all sagas with them.
There's also action_failure_can_unwind_idempotently for unwind actions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review issues #6069 and #6071 to understand the existing idempotency-testing helpers, then identify all sagas and their tests. Cover each saga with actions_succeed_idempotently and use action_failure_can_unwind_idempotently for unwind actions; done means all sagas have these checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100