oxidecomputer / oxidecomputer/omicron
Reconfigurator: Delete `Dataset` records for expunged zones
@smklein is already working on this.
Since Jul 12, 2024.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
#6065 ensures we create Dataset records for Omicron zones that have durable datasets, but nothing today removes records for expunged zones. @smklein noted this is more complicated for crucible zones:
e.g., the region replacement task currently does a big join of "given a region, look up the dataset, and given that dataset, look up the zpool, and given the zpool, look up the physical disk and check the policy"
so, leaving that query as-is, [we] can't actually delete the dataset rows until the region replacement task has finished
This is strongly related to #6042 (separating zone / dataset management) and lightly related to #6051 (we also never clean up Zpool rows).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.