oxidecomputer / oxidecomputer/omicron
Make image OS and version fields optional
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
We accept empty string as a non-null value, which is why these can be left empty in the web console, but then when creating images in the CLI and API, these fields are required (even though you can pass empty string). This is all a confusing state of affairs — if we allow empty string, we should probably just let them be null too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nexus/types/src/external_api/params.rs at lines 1858-1862, where the image OS and version parameters are defined. Compare how the web console, CLI, and API represent empty values, then update the API behavior so these fields consistently accept null as well as empty strings. Confirm that image creation through the CLI and API no longer requires non-null values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100