oxidecomputer / oxidecomputer/omicron
Error on attempt to delete disk in importing state should be more helpful
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
This is not that helpful a message unless the user is already looking at the relevant doc that would tell them what to do.
"disk cannot be deleted in state \"importing_from_bulk_writes\""
To be more helpful, we could look for that state and add another sentence to the effect of "In order to delete this disk, the import must be stopped and then finalized. Source here:
Related issues
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nexus/db-queries/src/db/datastore/disk.rs around lines 635-639, where the disk deletion state error is assembled. Check the handling of importing_from_bulk_writes and update the message with the stop-and-finalize guidance and documentation link described in the issue. Done means deletion attempts in that state provide the more helpful message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100