oxidecomputer / oxidecomputer/omicron
Deprecate the "lookup region port" task and make field non-optional.
Open
@jmpesp is already working on this.
Since Jun 28, 2024.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
https://github.com/oxidecomputer/omicron/pull/5955 adds a background task that will poll Crucible agents for the ports that regions were allocated with. This is required because ports were originally not recorded in CRDB, but after that PR lands they will be filled in. At some point in the future, all region records will have an associated port, and new allocations will record the port returned - at that time, deprecate this task, and make the port field non-optional.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.